Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More renaming from value type to inline type #113

Closed
wants to merge 1 commit into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented Jul 20, 2020

Please review this small patch with more renaming of symbols from "value type" to "inline type".

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Reviewers

  • Harold Seigel (hseigel - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/113/head:pull/113
$ git checkout pull/113

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

More renaming from value type to inline type

Reviewed-by: hseigel
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 1c8718afe3fe12b203cf31333e640cc1d2a61f99.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2020

Webrevs

Copy link
Member

@hseigel hseigel left a comment

The changes look good!
Thanks, Harold

@fparain
Copy link
Collaborator Author

@fparain fparain commented Jul 20, 2020

Thanks Harold!

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented Jul 20, 2020

/integrate

@openjdk openjdk bot closed this Jul 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2020

@fparain
Pushed as commit 2cd5c0e.

@fparain fparain deleted the more_renaming branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants