Skip to content

8336829: [lworld] serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jul 22, 2024

Run all versions of this test with -Xmx23m so that if CDS is off, the InMemoryCompiler will load without a Metaspace OOM. Also add a test to verify that new metadata created by inline/value classes are reclaimed, which I verified in gdb. Zeroed deallocated fields to help with manual verification.
Tested with jtreg/serviceability/jvmti/RedefineClasses tests.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8336829: [lworld] serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1174/head:pull/1174
$ git checkout pull/1174

Update a local copy of the PR:
$ git checkout pull/1174
$ git pull https://git.openjdk.org/valhalla.git pull/1174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1174

View PR using the GUI difftool:
$ git pr show -t 1174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1174.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2024

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2024

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336829: [lworld] serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • ca99443: 8336671: [lworld] Test java/lang/ref/ReferenceEnqueuePending.java fails when run with migrated classes
  • 82f977f: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2024

Webrevs

@coleenp
Copy link
Contributor Author

coleenp commented Jul 22, 2024

Thanks Fred.
/integrate

@openjdk openjdk bot added the sponsor label Jul 22, 2024
@openjdk
Copy link

openjdk bot commented Jul 22, 2024

@coleenp
Your change (at version 1259ffa) is now ready to be sponsored by a Committer.

@fparain
Copy link
Collaborator

fparain commented Jul 22, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 22, 2024

Going to push as commit c462c91.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • ca99443: 8336671: [lworld] Test java/lang/ref/ReferenceEnqueuePending.java fails when run with migrated classes
  • 82f977f: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jul 22, 2024

@fparain @coleenp Pushed as commit c462c91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the metaspace-oom branch July 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants