Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336390: [lworld] jdk/internal/util/ReferencedKeyTest.java fails with --enable-preview #1177

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Jul 23, 2024

ReferencedKeyTest uses Long to test the key maps.
However, with --enable-preview Long is a value class and cannot be used with Weak or Soft references.

Replace use of Long with String (an Identity class)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8336390: [lworld] jdk/internal/util/ReferencedKeyTest.java fails with --enable-preview (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1177/head:pull/1177
$ git checkout pull/1177

Update a local copy of the PR:
$ git checkout pull/1177
$ git pull https://git.openjdk.org/valhalla.git pull/1177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1177

View PR using the GUI difftool:
$ git pr show -t 1177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1177.diff

Webrev

Link to Webrev Comment

… --enable-preview

Replace use of Long with String (an Identity class)
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336390: [lworld] jdk/internal/util/ReferencedKeyTest.java fails with --enable-preview

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • c462c91: 8336829: [lworld] serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 23, 2024

Webrevs

@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2024

Going to push as commit b883585.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • c462c91: 8336829: [lworld] serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jul 24, 2024
@openjdk openjdk bot closed this Jul 24, 2024
@openjdk
Copy link

openjdk bot commented Jul 24, 2024

@RogerRiggs Pushed as commit b883585.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant