Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename load_value_type_fields_in_regs and store_value_type_fields_to_buf #120

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Jul 27, 2020

Hi,
Please review this small change to rename ()load_value_type_fields_in_regs to ()load_value_inline_type_fields_in_regs and rename ()store_value_type_fields_to_buf to ()store_inline_type_fields_to_buf.

The change was tested with tiers 1-2 and some of tier 3.
Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Reviewers

  • lfoltan (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/120/head:pull/120
$ git checkout pull/120

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 27, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

rename load_value_type_fields_in_regs and store_value_type_fields_to_buf
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 22265ecb412d857a1fbc51f7635295bc089bd6e5.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 27, 2020

Webrevs

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jul 27, 2020

Thanks Lois!

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jul 27, 2020

/integrate

@openjdk openjdk bot closed this Jul 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2020

@hseigel
Pushed as commit c5fb63d.

@hseigel hseigel deleted the rename_vt_fields branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants