Skip to content

Conversation

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Aug 22, 2024

this fix is removing internal option enableNullRestrictedTypes and making null restricted types for value classes a preview feature


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8338766: [lw5] remove option enableNullRestrictedTypes and make null-restricted types a preview feature (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1218/head:pull/1218
$ git checkout pull/1218

Update a local copy of the PR:
$ git checkout pull/1218
$ git pull https://git.openjdk.org/valhalla.git pull/1218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1218

View PR using the GUI difftool:
$ git pr show -t 1218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1218.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@vicente-romero-oracle vicente-romero-oracle changed the base branch from lworld to lw5 August 22, 2024 17:49
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338766: [lw5] remove option enableNullRestrictedTypes and make null-restricted types a preview feature

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lw5 branch:

  • 2b30981: API classes supporting RuntimeTypes and ArrayCreation bootstraps

Please see this link for an up-to-date comparison between the source branch of this pull request and the lw5 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lw5 branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2024

Webrevs

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

Going to push as commit 0b42d33.
Since your change was applied there has been 1 commit pushed to the lw5 branch:

  • 2b30981: API classes supporting RuntimeTypes and ArrayCreation bootstraps

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2024
@openjdk openjdk bot closed this Aug 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@vicente-romero-oracle Pushed as commit 0b42d33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the JDK-8338766 branch August 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant