Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250877: [lworld] Remove special acmp handling for isSubstitutable0 method in the JIT #126

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 31, 2020

The isSubstitutable0 Java method called by the VM to perform a substitutability test does not perform == on its arguments. Special casing can be removed from the JIT.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250877: [lworld] Remove special acmp handling for isSubstitutable0 method in the JIT

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/126/head:pull/126
$ git checkout pull/126

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250877: [lworld] Remove special acmp handling for isSubstitutable0 method in the JIT
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the lworld branch:

  • 448aaa0: 8242453: [lworld] C2 compilation fails with assert 'correct memory chain'
  • ef1a221: 8250962: [lworld] C2 should not replace redundant scalar replaceable allocations
  • e473d9d: 8244315: [lworld] The hierarchy between V$ref and V$val must be sealed
  • 5305fbd: 8244314: [lworld] V.ref and V.val are supposed to be nest mates
  • 72b3046: 8221323: [lworld] Javac should support class literals for projection types.
  • e40d6ba: 8250997: [lworld] Javac should not allow constructor reference expression to mention projection types
  • ae1759a: 8250234: [lworld] [lw3] jdk/valhalla/valuetypes/SubstitutabilityTest.java fails with C1
  • 6e6d0c7: 8250951: [lworld] Escape analysis fails due to oop access to flat array
  • 8895fbc: 8222784: [lworld] Remove stale compiler option: -XDallowGenericsOverValues
  • cecd9c5: 8250881: [lworld] Crash in AOT code with -XX:-EnableValhalla

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 448aaa0a3563fb0170410f273203b7498e6a3a92.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 31, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Aug 5, 2020

/integrate

@openjdk openjdk bot closed this Aug 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 5, 2020
@openjdk
Copy link

openjdk bot commented Aug 5, 2020

@TobiHartmann The following commits have been pushed to lworld since your change was applied:

  • 448aaa0: 8242453: [lworld] C2 compilation fails with assert 'correct memory chain'
  • ef1a221: 8250962: [lworld] C2 should not replace redundant scalar replaceable allocations
  • e473d9d: 8244315: [lworld] The hierarchy between V$ref and V$val must be sealed
  • 5305fbd: 8244314: [lworld] V.ref and V.val are supposed to be nest mates
  • 72b3046: 8221323: [lworld] Javac should support class literals for projection types.
  • e40d6ba: 8250997: [lworld] Javac should not allow constructor reference expression to mention projection types
  • ae1759a: 8250234: [lworld] [lw3] jdk/valhalla/valuetypes/SubstitutabilityTest.java fails with C1
  • 6e6d0c7: 8250951: [lworld] Escape analysis fails due to oop access to flat array
  • 8895fbc: 8222784: [lworld] Remove stale compiler option: -XDallowGenericsOverValues
  • cecd9c5: 8250881: [lworld] Crash in AOT code with -XX:-EnableValhalla

Your commit was automatically rebased without conflicts.

Pushed as commit f7f6929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant