Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250234: [lworld] [lw3] jdk/valhalla/valuetypes/SubstitutabilityTest.java fails with C1 #128

Closed
wants to merge 2 commits into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Jul 31, 2020

Please review this small changes to fix a bug in C1 transformations which cause an acmp involving inline types to be translated into a pointer comparison instead of a substitutability test.
The patch also includes a few fixes in C1 debugging features.

Thank you.

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250234: [lworld] [lw3] jdk/valhalla/valuetypes/SubstitutabilityTest.java fails with C1

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/128/head:pull/128
$ git checkout pull/128

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 31, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 31, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250234: [lworld] [lw3] jdk/valhalla/valuetypes/SubstitutabilityTest.java fails with C1

Reviewed-by: thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the lworld branch:

  • 6e6d0c7: 8250951: [lworld] Escape analysis fails due to oop access to flat array
  • 8895fbc: 8222784: [lworld] Remove stale compiler option: -XDallowGenericsOverValues
  • cecd9c5: 8250881: [lworld] Crash in AOT code with -XX:-EnableValhalla

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 6e6d0c7153b94f3fbc8bb749b33b68fa3d42863c.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 31, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me. Thanks for fixing!

@fparain
Copy link
Collaborator Author

@fparain fparain commented Aug 3, 2020

Thanks Tobias!

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented Aug 3, 2020

/integrate

@openjdk openjdk bot closed this Aug 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2020

@fparain The following commits have been pushed to lworld since your change was applied:

  • 6e6d0c7: 8250951: [lworld] Escape analysis fails due to oop access to flat array
  • 8895fbc: 8222784: [lworld] Remove stale compiler option: -XDallowGenericsOverValues
  • cecd9c5: 8250881: [lworld] Crash in AOT code with -XX:-EnableValhalla

Your commit was automatically rebased without conflicts.

Pushed as commit ae1759a.

@fparain fparain deleted the c1_subst_failure branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants