Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250951: [lworld] Escape analysis fails due to oop access to flat array #130

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 3, 2020

When storing null, C2 should only mark array as not-flat after the null-check.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250951: [lworld] Escape analysis fails due to oop access to flat array

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/130/head:pull/130
$ git checkout pull/130

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250951: [lworld] Escape analysis fails due to oop access to flat array
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 8895fbcc4c6f68f63a6abacf886b7d08d585ea5a.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 3, 2020

/integrate

@openjdk openjdk bot closed this Aug 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2020

@TobiHartmann
Pushed as commit 6e6d0c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant