Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Feb 13, 2025

Testing: 3 updated tests, tier 1-3 in progress


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8327214: [lworld] Valhalla compiler testing move to classfile API (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1365/head:pull/1365
$ git checkout pull/1365

Update a local copy of the PR:
$ git checkout pull/1365
$ git pull https://git.openjdk.org/valhalla.git pull/1365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1365

View PR using the GUI difftool:
$ git pr show -t 1365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1365.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327214: [lworld] Valhalla compiler testing move to classfile API

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2025

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce, thanks for the clean up !

@MrSimms
Copy link
Member

MrSimms commented Feb 13, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@MrSimms The change author (@liach) must issue an integrate command before the integration can be sponsored.

@liach
Copy link
Member Author

liach commented Feb 13, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 13, 2025
@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@liach
Your change (at version 2e8ee14) is now ready to be sponsored by a Committer.

@MrSimms
Copy link
Member

MrSimms commented Feb 13, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

Going to push as commit 991ec92.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2025
@openjdk openjdk bot closed this Feb 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 13, 2025
@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@MrSimms @liach Pushed as commit 991ec92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants