Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lworld] clean up VarHandle support for inline type #140

Closed
wants to merge 12 commits into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Aug 10, 2020

InlineAccessor and StaticInlineAccessor are no longer needed because Class::cast will ensure the given object is non-null if it's an inline object.


Progress

  • Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/140/head:pull/140
$ git checkout pull/140

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 10, 2020

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@mlchung This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

[lworld] clean up VarHandle support for inline type
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 59d8f6b4607d676bd7310857c38a3b6918aa3cc4.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 10, 2020

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Aug 10, 2020

/integrate

@mlchung mlchung closed this Aug 10, 2020
@mlchung mlchung reopened this Aug 10, 2020
@openjdk openjdk bot closed this Aug 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@mlchung
Pushed as commit 67a019a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant