Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251842: rename ACC_VALUE to ACC_INLINE #145

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Aug 14, 2020

Change ACC_VALUE to ACC_INLINE and change JVM_ACC_VALUE to JVM_ACC_INLINE. Tested with tiers 1-2 on Linux, MAC, and Windows, and tiers 3-5 on Linux.


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

  • Frederic Parain (fparain - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/145/head:pull/145
$ git checkout pull/145

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 14, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251842: rename ACC_VALUE to ACC_INLINE

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 2455c8ede34224fc5b66be222c95e6cfafbd630c.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 14, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@hseigel
Copy link
Member Author

@hseigel hseigel commented Aug 14, 2020

Thanks Fred!

@hseigel
Copy link
Member Author

@hseigel hseigel commented Aug 14, 2020

/integrate

@openjdk openjdk bot closed this Aug 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2020

@hseigel
Pushed as commit 2c019fd.

@hseigel hseigel deleted the rname_ACC_VALUE branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants