Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251504: [lworld] Support empty inline classes without -XDallowEmptyValues #146

Closed
wants to merge 1 commit into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Aug 17, 2020

Support empty inline classes


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8251504: [lworld] Support empty inline classes without -XDallowEmptyValues

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/146/head:pull/146
$ git checkout pull/146

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251504: [lworld] Support empty inline classes without -XDallowEmptyValues
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 191 commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 2c019fdf352d5dc98902afc76bfb79e3450d56e0.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Aug 17, 2020

/integrate

@openjdk openjdk bot closed this Aug 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2020

@sadayapalam The following commits have been pushed to lworld since your change was applied:

  • 2c019fd: 8251842: rename ACC_VALUE to ACC_INLINE
  • 2455c8e: 8251398: [lworld] TestCallingConvention::test36 spuriously fails due to incorrect field value
  • f0a8efc: Merge jdk
  • 93cde00: Merge jdk
  • 13b7c2e: 8244724: CTW: C2 compilation fails with "Live Node limit exceeded limit"
  • 2a37607: 8248563: Gtest CFLAGS/warnings is not properly handled
  • f567358: 8248526: configure script failed on WSL in May 2020 update
  • 545d56d: Merge
  • 7d54e71: 8246493: JDI stress/serial/mixed002 needs to use WhiteBox.deflateIdleMonitors support
  • 46ff8fd: 8248409: some jdk/javadoc/doclet tests fail (JDK 15)
  • 7c3d72f: Merge
  • 0f43de9: 8246114: java/net/MulticastSocket/Promiscuous.java fails after 8241072 (multi-homed systems)
  • 13750b6: 8248048: ZGC: AArch64: SIGILL in load barrier register spilling
  • abc55de: 8248485: Poor scalability in JfrCheckpointManager when using many threads after JDK-8242008
  • a338213: 8248545: Remove unneeded warning suppression of MSVC++ 4521/4522
  • eb1bacc: 8248475: Suppress unconditional warning "JFR will be disabled during CDS dumping"
  • 2de3595: 8248548: Use DISABLED_WARNINGS for globally disabled warnings on Visual Studio in Hotspot
  • f19db79: 8248547: Use SetupJdkLibrary for hotspot libraries
  • 622117d: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101"
  • 20a1e35: 8248492: ProblemList open/test/langtools//jdk/javadoc/doclet/testHeadTag/TestHeadTag.java
  • 46f8647: 8248346: Move OopStorage mutex setup out from OopStorageSet
  • 51b7c76: 8245129: Enhance jstat gc option output and tests
  • ba711f6: 8248410: Correct Fix for 8236647: java/lang/invoke/CallSiteTest.java failed with InvocationTargetException in Graal mode
  • 682e836: 8248488: JDK-8246484 actually broke COMPARE_BUILD
  • 5a6954a: 8246051: SIGBUS by unaligned Unsafe compare_and_swap
  • 840867e: 8247218: Add default constructor to VectorSet to use Thread::current()->resource_area() as arena by default
  • fe14564: 8248227: Shenandoah: Refactor Shenandoah::heap() to match other GCs
  • c07ce7e: 8245245: Websocket can lose the URL encoding of URI query parameters
  • 55bbaf1: 8248273: Small clean up for PerfClassTraceTime
  • 48c0ce3: 8247408: IdealGraph bit check expression canonicalization
  • a25bacd: 8248234: Disabling UseExactTypes crashes C2
  • a793293: 8247845: Shenandoah: refactor TLAB/GCLAB retirement code
  • 5ad963c: 8248379: Handshake closures for JVMTI monitor functions lack of some validations
  • 9d67970: Merge
  • ac4f14c: 8247307: C2: Loop array fill stub routines are not called
  • f44f885: 8248044: Backout ProblemList-ed tests introduced by JDK-8247876
  • a2db08a: 8247438: JShell: When FailOverExecutionControlProvider fails the proximal cause is not shown
  • bdab5a0: 8248428: Cleanup pass on javax.lang.model docs
  • 1ef33e4: 8248168: [Graal] jck tests timeout in Graal with -Xcomp mode
  • a0a0539: 8248112: array index out of bound in FileMapInfo::check_paths
  • f6c537f: 8247438: JShell: When FailOverExecutionControlProvider fails the proximal cause is not shown
  • fc82a46: 8248412: test/jdk/java/sql/testng/test/sql/DriverManagerPermissionsTests.java can fail
  • c0c4a8d: 8248326: Add a minimal serialization test for local records
  • 57b792c: 8248216: JFR: Unify handling of all OopStorage instances in LeakProfiler root processing
  • 18cddad: 8247819: G1: Process strong OopStorage entries in parallel
  • 51ddc2a: 8246337: Add more JVM tests for sealed classes
  • e7fa180: 8248334: hs build errors on ppc64 and s390x platforms
  • 9ffba30: 8247747: Remove macro definition of "inline" in stack.hpp
  • 55b4722: Merge
  • b87302c: 8248347: windows build broken by JDK-8243114
  • 2534e72: 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX
  • e098a31: 8248351: ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows
  • 708b60e: 8248354: ProblemList vmTestbase/nsk/jdi/stress/serial/mixed002/TestDescription.java
  • fc82768: 8247849: permits clause of sealed interfaces should not allow parameterized types
  • 23bbc98: 8248302: JFR: Add test for OldObjectSample event when using ZGC
  • 4682835: 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong
  • 8a42442: 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java
  • 5724c0d: 8248339: ProblemList jdk/jfr/event/os/TestThreadContextSwitches.java
  • b4ea9cf: 8248335: ProblemList compiler/ciReplay/TestServerVM.java and TestVMNoCompLevel.java with AOT
  • e00aa7c: 8248329: JDK-8244603 breaks windows build
  • aacb827: 8220639: Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line
  • d886d8c: 8247730: 2 JNI exception pending defect groups in DwarfParser.cpp
  • 47e465c: 8243114: Implement montgomery{Multiply,Square}intrinsics on Windows
  • 0f2ac20: 8244603: G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
  • 8c20401: 8243672: Short term pause time ratio calculation in G1 off
  • a953a0f: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header
  • a6e794b: 8248240: Remove extendedPC.hpp and fetch_frame_from_ucontext
  • 06cea10: 8248271: linux-x86-zero build failure
  • 601e566: 8245128: Kitchensink fails with: assert(destination == (address)-1 || destination == entry) failed: b) MT-unsafe modification of inline cache
  • 31c511e: 8246704: --release => "unknown enum constant PreviewFeature$Feature.TEXT_BLOCKS"
  • 42d3bad: 8248233: Avoid superfluous Class::isRecord invocations during deserialization
  • 233cac3: Merge
  • 9e5f688: Added tag jdk-16+3 for changeset 76810b3a88c8
  • 34755c3: Added tag jdk-15+29 for changeset b58fc6058055
  • f45d121: 8248255: [macos] Add failing DMG tests to problem list
  • ac37a29: 8248049: minor cleanups in gc/whitebox/TestWBGC.java
  • 3e4ad5d: 8246477: add whitebox support for deflating idle monitors
  • 362f168: 8242501: JFR: oldobject/TestG1.java can't find leaking object
  • 2ad6386: 8247573: gtest/GTestWrapper.java is not helpful if gtest framework is missing
  • 1e45eb3: 8248235: appcds/jigsaw/PatchModule/Simple.java failed when running in dynamic CDS mode
  • 95b9024: 8164597: TestIOException.java fails after push for JDK-8164130
  • 4b3c33b: 8247785: Small clarification of the javadoc about builtin class loaders
  • 0e60e8a: 8246181: Avoid walking SymbolTable during -Xshare:dump
  • 1550fd8: 8239782: CC_INTERP is only used by Zero interpreter
  • 6b25119: 8248131: Simplify ServicesCatalog provider handling
  • 112a4bd: 8247966: runtime/logging/loadLibraryTest/LoadLibraryTest.java failed "RuntimeException: 'Unloaded library with handle' missing from stdout/stderr"
  • 9584e01: 8225251: Minimise import statements in jpackage sources
  • ef3b0ec: 8247755: Leaner and more versatile GrowableArray classes
  • 9d6aa42: 8247820: ParallelGC: Process strong OopStorage entries in parallel
  • 3797364: 8248133: SerialGC: Unify handling of all OopStorage instances in root processing
  • 156f617: 8248132: ZGC: Unify handling of all OopStorage instances in root processing
  • a1f02d1: 8248130: AArch64: pf() uses mtNone instead of mtInternal
  • 27fc8b6: 8246546: Simplify SystemDictionary::is_shared_class_visible
  • e178f04: 8248184: AMPM_OF_DAY doc fix in ChronoField
  • 1aa6539: 8241885: JFR tool: print does not work with inner class events
  • 0a6262f: 8242593: JFR: EventFactory does not scale well past unique 1000 events
  • d85ff3c: 8246212: JPKG001-012: application icon is missing in Control Panel Add/Remove
  • 2993654: 8247246: Add explicit ResolvedJavaType.link and expose presence of default methods
  • 6715f23: 8241718: assert ((klass)->trace_id()) & ((JfrTraceIdEpoch::method_and_class_in_use_this_epoch_bits()))) != 0 in ObjectSampleCheckpoint::add_to_leakp_set
  • 2f09989: 8247532: Records deserialization is slow
  • 4bcd70a: 8247967: SparkExamples24H.java SIGSEGV in various places
  • e66a2a3: 8247955: doclint: don't complain about summary/caption when role=presentation
  • 4076ca8: 8151779: Some intrinsic flags could be replaced with one general flag
  • 6986ab2: 8248041: Shenandoah: pre-Full GC root updates may miss some roots
  • 1e1985d: 8247956: remove scripts under bin/nashorn and doc/nashorn/source
  • 36d716a: 8248011: Improve javadoc of Foreign Memory Access API
  • 7f69acc: 8247696: Incorrect tail computation for large segments in AbstractMemorySegmentImpl::mismatch
  • 6469685: 8247992: [JVMCI] HotSpotNmethod.executeVarargs can try execute a zombie nmethod
  • 4167ba1: 8248061: bad reference in @throws in HotSpotDiagnosticMXBean
  • 12554c2: 8244818: Java2D Queue Flusher crash while moving application window to external monitor
  • 9a99f51: 8247958: minor HTML errors in com.sun.jdi
  • 9a120e7: 8247959: doclint errors in NIO code
  • cb9d3ef: 8247979: aarch64: missing side effect of killing flags for clearArray_reg_reg
  • c0b348f: 8239950: Update PKCS9 Attributes to PKCS#9 v2.0 Encodings
  • d8219d0: 8213214: Set -Djava.io.tmpdir= when running tests
  • 2765410: 8247319: Remove on-stack nmethod hotness counter sampling from safepoints
  • a10a928: 8247179: Mechanism for VM operations to not take part in safepoint coalescing
  • 88df2f0: 8243470: [macos] bring back O2 opt level for unsafe.cpp
  • f8596b5: 8247740: Inline derived CollectedHeap access for G1 and ParallelGC
  • e3eb38f: 8244148: keytool -printcert and -printcrl should support the -trustcacerts and -keystore options
  • 8d9826e: 8247995: Avoid use of a mapping function in Permissions.getPermissionCollection
  • 17f2250: 8247879: Rework WeakHandle and OopHandle to dynamically support different OopStorages
  • b7e9449: Merge
  • 4862d0d: Merge
  • 3192ef3: 8247736: Shenandoah: assert(_nm->is_alive()) failed: only alive nmethods here
  • 61e44cd: 8247932: JShell crashes when typing text block
  • eb758d5: 8247763: assert(outer->outcnt() == 2) failed: 'only phis' failure in LoopNode::verify_strip_mined()
  • f834dc3: 8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private
  • c4df791: 8247907: XMLDsig logging does not work
  • 25b1e5a: 8247876: ProblemList various crypto tests on aarch64
  • e0a7782: 8247784: Bad link causes invalid documentation
  • 8b6d314: 8247815: doclint: recategorize "no description for ..." as MISSING, not SYNTAX
  • 2e6923f: 8243533: Only one of several deprecated overloaded methods listed in the Deprecated list
  • 9d40d80: 8247780: Refine the Help page for API Documentation
  • f2b191a: 8247444: Trust final fields in records
  • 983e012: 8241969: Type annotation is not shown for wildcard type in Javadoc
  • ffbee17: 8198705: Javadoc search needs a fix to handle duplicate package names in different modules
  • 226e852: 8242214: NullPointerException in JDK 14 javac compiling a method reference
  • 5d1255b: 8246078: Javadoc Search specification link from Javadoc Help page points to JDK 13 spec
  • 326ba31: 8237950: C2 compilation fails with "Live Node limit exceeded limit" during ConvI2L::Ideal optimization
  • bf1e690: 8233014: Enable ShowCodeDetailsInExceptionMessages by default
  • e208d9a: 8247899: HTML errors and warnings in threadPrimitiveDeprecation.html
  • 5103544: 8247896: Invalid (@throw) tags in 2 java.io classes
  • 6c2c056: 8247894: Invalid @see in java.management
  • 2155d52: 8247880: bad HTML(href==...) in table
  • de3923e: 8247788: DocCommentParser should not reject standalone '>'
  • 05dc2af: 8247824: CTW: C2 (Shenandoah) compilation fails with SEGV in SBC2Support::pin_and_expand
  • d5ae932: 8248265: compiler/ciReplay tests fail with AOT compiled java.base
  • a7e352b: 8246051: SIGBUS by unaligned Unsafe compare_and_swap
  • 144267d: 7107012: sun.jvm.hostspot.code.CompressedReadStream readDouble() conversion to long mishandled
  • d19f2bd: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101"
  • 320af9b: 8248264: WinUpgradeUUIDTest application is missing in downgrade scenario
  • d180fb3: 8248254: jpackage fails if app module is in external runtime
  • 1a4f314: 8248427: jpackage jtreg BasicTest.testTemp() test fails on Windows
  • d16ea55: 8236647: Correct Fix for 8236647: java/lang/invoke/CallSiteTest.java failed with InvocationTargetException in Graal mode
  • 97cdfb9: 8247832: [Graal] Many Javafuzzer tests failures with Graal, due to unexpected results, after last update JDK-8243380
  • a750ac5: 8247358: Shenandoah: reconsider free budget slice for marking
  • 56048d0: 8247789: Remove use of reflection from test/jdk/java/io/Serializable/records/StreamRefTest.java
  • 11ac92c: 8246244: BasicShortcutHintTest shortcut can not be found
  • cfab7f4: 8247778: ZGC: More parallel gc/z/TestUncommit.java test configuration
  • 2cbdd21: 8241802: [Graal] compiler/loopopts/TestLogSum.java timed out
  • 59a4517: Added tag jdk-15+28 for changeset 06c9f89459da
  • ecb4cbf: 8245842: provide tests for binary compatibility assertions for sealed classes
  • ce4978f: 8246257: Annotated record's vararg type component started to be uncompilable with JDK15b24
  • 2a794b6: 8245696: javadoc crashes when a doc-files directory contains a '#' file
  • ed4b801: 8238735: NPE compiling lambda expression within conditional expression
  • 338dd21: 8247725: move two tests for whitebox from test/hotspot/jtreg/sanity to test/lib-test
  • f740cda: 8247716: JVM_RegisterWhiteBoxMethods checks wrong classloader
  • 5547d32: 8247200: assert((unsigned)fpargs < 32)
  • 732d886: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • 5adfaa3: 8247763: assert(outer->outcnt() == 2) failed: 'only phis' failure in LoopNode::verify_strip_mined()
  • 04adafb: 8247901: Multiple conflicting @return for FlightRecorderMXBean
  • 3576a88: 8246436: JFR: Avoid parsing metadata.xml during startup
  • 927a728: 8247907: XMLDsig logging does not work
  • 5bd6e9d: 8247876: ProblemList various crypto tests on aarch64
  • 4ef42b9: 8247760: Improve documentation for javadoc.tester.JavadocTester
  • cd33547: 8247729: GetObjectMonitorUsage() might return inconsistent information
  • 651c20d: 8247697: Remove delayed_forbidden dead code in C2
  • a16994f: Merge
  • 0bacc69: 8247860: Shenandoah: add update watermark line in rich assert failure message
  • 2627f15: 8238832: Obsolete PrintVMQWaitTime
  • 9a26a01: Added tag jdk-16+2 for changeset bcbe7b8a77b8
  • 07f9376: 8246369: CodeCache.findBlobUnsafe(addr) sometimes asserts with valid address
  • 1cb5a48: 8245588: Update --release 15 symbol information for JDK 15 build 27
  • 175b597: 8247706: Unintentional use of new Date(year...) with absolute year
  • 4f2edac: 8247782: typos in java.math
  • 34c7964: 8247681: Improve bootstrapping of unary concatenations
  • 1d87958: 8243113: Always identify version of javadoc used to generate docs
  • 44d4e37: 8247757: Shenandoah: split heavy tests by heuristics to improve parallelism
  • 00dc525: 8247754: Shenandoah: mxbeans tests can be shorter
  • d2c1027: 8247751: Shenandoah: options tests should run with smaller heaps

Your commit was automatically rebased without conflicts.

Pushed as commit 77af809.

@openjdk openjdk bot removed the rfr label Aug 17, 2020
@sadayapalam sadayapalam deleted the JDK-8251504 branch Aug 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant