Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244232: [lworld] Improve javadoc comments for various methods dealing with projection types #148

Closed
wants to merge 1 commit into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Aug 18, 2020

Update javadoc to reflect differences between referenceProjection APIs and the ref operator of the spec.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244232: [lworld] Improve javadoc comments for various methods dealing with projection types

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/148/head:pull/148
$ git checkout pull/148

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244232: [lworld] Improve javadoc comments for various methods dealing with projection types
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate f72ec3c37f69709a473989d91df302144242a4f7.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Aug 18, 2020

/integrate

@openjdk openjdk bot closed this Aug 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@sadayapalam
Pushed as commit 212077b.

@sadayapalam sadayapalam deleted the JDK-8244232 branch Aug 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant