Skip to content

8361307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects#1513

Closed
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
RogerRiggs:8361307-identity-cleanup
Closed

8361307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects#1513
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
RogerRiggs:8361307-identity-cleanup

Conversation

@RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Jul 21, 2025

Javadoc updates to clarify value class vs identity class distinctions when in preview-mode and not.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8361307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1513/head:pull/1513
$ git checkout pull/1513

Update a local copy of the PR:
$ git checkout pull/1513
$ git pull https://git.openjdk.org/valhalla.git pull/1513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1513

View PR using the GUI difftool:
$ git pr show -t 1513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1513.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2025

Webrevs

@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

Going to push as commit 3626f88.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 1fdd381: 8363956: [lworld] Valhalla vauetypes tests enablePreview should be per test
  • d1c3062: 8349110: [lworld] Intrinsics for Unsafe.get/putFlatValue

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2025
@openjdk openjdk bot closed this Jul 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@RogerRiggs Pushed as commit 3626f88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8361307-identity-cleanup branch February 3, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant