Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250764: [lworld] Merge JDK-8247697 in from mainline #153

Closed
wants to merge 2 commits into from

Conversation

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Aug 19, 2020

Brought the change for 8247697 in. Tweaked
LateInlineMHCallGenerator::do_late_inline_check() so behavior with
+AlwaysIncrementalInline is unchanged an our tests pass.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250764: [lworld] Merge JDK-8247697 in from mainline

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/153/head:pull/153
$ git checkout pull/153

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2020

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2020

@rwestrel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250764: [lworld] Merge JDK-8247697 in from mainline

Reviewed-by: thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 5d1350ef32eba34258f5e700d2637c8a0a95dd99.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me. Maybe add a comment to the changes in LateInlineMHCallGenerator::do_late_inline_check and remove the extra brackets in doCall.cpp:188.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2020

Mailing list message from Roland Westrelin on valhalla-dev:

Looks good to me. Maybe add a comment to the changes in LateInlineMHCallGenerator::do_late_inline_check and remove the
extra brackets in doCall.cpp:188.

I'll do that. Thanks for the review.

Roland.

@rwestrel
Copy link
Collaborator Author

@rwestrel rwestrel commented Aug 20, 2020

/integrate

@openjdk openjdk bot closed this Aug 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@rwestrel
Pushed as commit b697e16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants