Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Sep 3, 2025

The missing link points to the preview note on Attributes::loadableDescriptors. Simply marking this API as preview fixes it.

Also I fixed the since version from 23 to Valhalla.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8366802: [lworld] jdk/javadoc/doccheck/checks/jdkCheckLinks.java fails since jdk-26+26 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1542/head:pull/1542
$ git checkout pull/1542

Update a local copy of the PR:
$ git checkout pull/1542
$ git pull https://git.openjdk.org/valhalla.git pull/1542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1542

View PR using the GUI difftool:
$ git pr show -t 1542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1542.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 3, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366802: [lworld] jdk/javadoc/doccheck/checks/jdkCheckLinks.java fails since jdk-26+26

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2025

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks !

@liach
Copy link
Member Author

liach commented Sep 3, 2025

Will integrate once CI is clear.

@liach
Copy link
Member Author

liach commented Sep 3, 2025

Turns out this requires a docs profile to run on CI, but since this passes locally with local docs I will assume this is good.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 3, 2025

Going to push as commit 480094c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2025
@openjdk openjdk bot closed this Sep 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2025
@openjdk
Copy link

openjdk bot commented Sep 3, 2025

@liach Pushed as commit 480094c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants