8366267: [lworld] Injected ACC_IDENTITY escapes to instrumentation of older classes

[coleenp]

This is a simple fix to mask off the ACC_IDENTITY bit from the inner class attribute that was added in during classfile parsing for non-preview non-value classfiles.
Tested with tier1 and java/lang/instrument manually.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8366267: [lworld] Injected ACC_IDENTITY escapes to instrumentation of older classes (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1547/head:pull/1547
$ git checkout pull/1547

Update a local copy of the PR:
$ git checkout pull/1547
$ git pull https://git.openjdk.org/valhalla.git pull/1547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1547

View PR using the GUI difftool:
$ git pr show -t 1547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1547.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366267: [lworld] Injected ACC_IDENTITY escapes to instrumentation of older classes

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (aa1d3486)

[liach]

Thank you for this fix!

[coleenp]

Thanks for reporting it and suggested fix, Chen.
/integrate

[openjdk]

Going to push as commit 59ffa2d.

[openjdk]

@coleenp Pushed as commit 59ffa2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.