Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Sep 4, 2025

@Arraying discovered that java.lang.classfile.ClassFile is missing a constant for ACC_STRICT_INIT. This was due to previous iterations of strict fields proposal calling this flag simply ACC_STRICT like strictfp. The usages of ACC_STRICT and Modifier.STRICT has been reviewed, and ones that actually refer to STRICT_INIT (which is also not a source modifier) are migrated.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8366913: [lworld] Add ACC_STRICT_INIT to ClassFile (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1548/head:pull/1548
$ git checkout pull/1548

Update a local copy of the PR:
$ git checkout pull/1548
$ git pull https://git.openjdk.org/valhalla.git pull/1548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1548

View PR using the GUI difftool:
$ git pr show -t 1548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1548.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366913: [lworld] Add ACC_STRICT_INIT to ClassFile

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 59ffa2d: 8366267: [lworld] Injected ACC_IDENTITY escapes to instrumentation of older classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2025

Webrevs

@liach
Copy link
Member Author

liach commented Sep 4, 2025

No new failure in tier 1-3, integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

Going to push as commit 2fddd34.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 59ffa2d: 8366267: [lworld] Injected ACC_IDENTITY escapes to instrumentation of older classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2025
@openjdk openjdk bot closed this Sep 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2025
@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@liach Pushed as commit 2fddd34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant