8366913: [lworld] Add ACC_STRICT_INIT to ClassFile #1548
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Arraying discovered that java.lang.classfile.ClassFile is missing a constant for ACC_STRICT_INIT. This was due to previous iterations of strict fields proposal calling this flag simply ACC_STRICT like strictfp. The usages of ACC_STRICT and Modifier.STRICT has been reviewed, and ones that actually refer to STRICT_INIT (which is also not a source modifier) are migrated.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1548/head:pull/1548$ git checkout pull/1548Update a local copy of the PR:
$ git checkout pull/1548$ git pull https://git.openjdk.org/valhalla.git pull/1548/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1548View PR using the GUI difftool:
$ git pr show -t 1548Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1548.diff
Using Webrev
Link to Webrev Comment