New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8252061 [lword] Support Object::toString for inline type #155
Conversation
|
@mlchung This change now passes all automated pre-integration checks, type
Since the source branch of this PR was last updated there have been 198 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
A couple of comments:
|
/integrate |
@mlchung The following commits have been pushed to lworld since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit acfed88. |
This adds the
Object::toString
support for inline classes. This will replace the needfor javac to generate the
toString
method to call the bootstrap method.JDK-8206077 will revisit the overlap of
ValueBootstrapMethods
andObjectMethods
.This patch also removes the private
isSubstituable0
method and makes surethat
isSubstitutable
does not haveacmp
instruction and can be invoked by VM.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/155/head:pull/155
$ git checkout pull/155