Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251527: CTW: C2 (Shenandoah) compilation fails with SEGV due to unhandled catchproj == NULL #156

Closed
wants to merge 1 commit into from

Conversation

rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Aug 20, 2020

In PhaseIdealLoop::flatten_array_element_type_check(), when pushing:

(LoadKlass (AddP (CastPP ...

through a Phi, the control of CastPP clone is set to region->in(i) but
the AddP clone control is set to get_ctrl(phi->in(i)) which can be
above region->in(i) while the AddP is below the CastPP. Fix is to use
region->in(i) for all clones.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8251527: CTW: C2 (Shenandoah) compilation fails with SEGV due to unhandled catchproj == NULL

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/156/head:pull/156
$ git checkout pull/156

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2020

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2020

@rwestrel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251527: CTW: C2 (Shenandoah) compilation fails with SEGV due to unhandled catchproj == NULL
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 5d1350ef32eba34258f5e700d2637c8a0a95dd99.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Aug 20, 2020

Webrevs

@rwestrel
Copy link
Collaborator Author

rwestrel commented Aug 20, 2020

Used incorrect bug id. Closing it,

@rwestrel rwestrel closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant