Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250511: [lworld] C2 compilation crashes in PhaseIdealLoop::spinup #157

Closed
wants to merge 1 commit into from

Conversation

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Aug 20, 2020

In PhaseIdealLoop::flatten_array_element_type_check(), when pushing:

(LoadKlass (AddP (CastPP ...

through a Phi, the control of CastPP clone is set to region->in(i) but
the AddP clone control is set to get_ctrl(phi->in(i)) which can be
above region->in(i) while the AddP is below the CastPP. Fix is to use
region->in(i) for all clones.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250511: [lworld] C2 compilation crashes in PhaseIdealLoop::spinup

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/157/head:pull/157
$ git checkout pull/157

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 20, 2020

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@rwestrel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250511: [lworld] C2 compilation crashes in PhaseIdealLoop::spinup

Reviewed-by: thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • b697e16: 8250764: [lworld] Merge JDK-8247697 in from mainline

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate b697e163c8e92cad39f4815e2a1c5c5eac15143b.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@rwestrel
Copy link
Collaborator Author

@rwestrel rwestrel commented Aug 20, 2020

/integrate

@openjdk openjdk bot closed this Aug 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@rwestrel The following commits have been pushed to lworld since your change was applied:

  • b697e16: 8250764: [lworld] Merge JDK-8247697 in from mainline

Your commit was automatically rebased without conflicts.

Pushed as commit 2bde31f.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2020

Mailing list message from Roland Westrelin on valhalla-dev:

Looks good to me.

Thanks for the review.

Roland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants