Skip to content

8367518: TestRedundantLea.java fails in Valhalla #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhaessig wants to merge 5 commits into from
Closed

8367518: TestRedundantLea.java fails in Valhalla #1605

mhaessig wants to merge 5 commits into from

Conversation

@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Sep 22, 2025 •
edited by openjdk bot
Loading

After merging TestRedundantLea.java into valhalla it turned out that the StringInflate and StoreN* subtests fail. This PR fixes that by bringing over two commits from mainline that fix problems with this test, which already fixes StringInflate.

The problem with the StoreN cases is that with valhalla C2 does not generate spills that the peephole can remove. To still test removing spills I came up with a new test case specifically for spills.

Testing:

  • tier1,tier2 plus some stress testing

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8367518: TestRedundantLea.java fails in Valhalla (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1605/head:pull/1605
$ git checkout pull/1605

Update a local copy of the PR:
$ git checkout pull/1605
$ git pull https://git.openjdk.org/valhalla.git pull/1605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1605

View PR using the GUI difftool:
$ git pr show -t 1605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1605.diff

Using Webrev

Link to Webrev Comment

mhaessig and others added 4 commits September 18, 2025 16:54
@mhaessig @MBaesken
8361040: compiler/codegen/TestRedundantLea.java#StringInflate fails w…
9c953dc 
…ith failed IR rules

Co-authored-by: Matthias Baesken <mbaesken@openjdk.org>
Reviewed-by: chagedorn, mbaesken
@mhaessig
8360175: C2 crash: assert(edge_from_to(prior_use,n)) failed: before b…
aff8d1f 
…lock local scheduling

Reviewed-by: kvn, chagedorn
@mhaessig
Unproblemlist TestRedundantLea#InflateString
a64fa02
@mhaessig
Fix TestRedundantLea an un-problem-list
6119e5e
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025 •
edited
Loading

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367518: TestRedundantLea.java fails in Valhalla

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 431 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2025 •
edited
Loading

Webrevs

chhagedorn
chhagedorn approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this and adding an additional test case!

test/hotspot/jtreg/compiler/codegen/TestRedundantLea.java
}

@Test
// TODO: Make tests more precise
Copy link
Member

@chhagedorn chhagedorn Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that was already there for mainline but I'm wondering, is there a tracking issue for that?

Copy link
Contributor Author

@mhaessig mhaessig Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is JDK-8361089

@mhaessig @chhagedorn
Apply suggestions from Christian
10670b6 
Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
@mhaessig
Copy link
Contributor Author

mhaessig commented Sep 23, 2025

Thank you for reviewing, Christian!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@mhaessig
Your change (at version 10670b6) is now ready to be sponsored by a Committer.

@chhagedorn
Copy link
Member

chhagedorn commented Sep 24, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

Going to push as commit 01225ee.
Since your change was applied there have been 438 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2025
@openjdk openjdk bot closed this Sep 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@chhagedorn @mhaessig Pushed as commit 01225ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mhaessig mhaessig mentioned this pull request Sep 25, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chhagedorn chhagedorn chhagedorn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhaessig @chhagedorn