Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252109: [lworld] C2 compilation fails with assert(!has_phi_inputs(region)) failed: already cloned with phis #161

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 20, 2020

Assert is too strong because during a PhiNode::Ideal transformation, some inputs of an InlineTypeNode might already be PhiNodes of the same region.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252109: [lworld] C2 compilation fails with assert(!has_phi_inputs(region)) failed: already cloned with phis

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/161/head:pull/161
$ git checkout pull/161

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 20, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252109: [lworld] C2 compilation fails with assert(!has_phi_inputs(region)) failed: already cloned with phis
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the lworld branch:

  • a5aa3a9: 8251986: [lworld] implement Class::valueType and Class::referenceType in Java
  • 2bde31f: 8250511: [lworld] C2 compilation crashes in PhaseIdealLoop::spinup
  • b697e16: 8250764: [lworld] Merge JDK-8247697 in from mainline

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate a5aa3a9d262d20caaa58f9306ec6cd02f62d8bbe.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2020

Webrevs

@TobiHartmann TobiHartmann changed the title 8252109: [lworld] C2 compilation fails with assert(\!has_phi_inputs(region)) failed: already cloned with phis 8252109: [lworld] C2 compilation fails with assert(!has_phi_inputs(region)) failed: already cloned with phis Aug 20, 2020
@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 21, 2020

/integrate

@openjdk openjdk bot closed this Aug 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 21, 2020

@TobiHartmann The following commits have been pushed to lworld since your change was applied:

  • a5aa3a9: 8251986: [lworld] implement Class::valueType and Class::referenceType in Java
  • 2bde31f: 8250511: [lworld] C2 compilation crashes in PhaseIdealLoop::spinup
  • b697e16: 8250764: [lworld] Merge JDK-8247697 in from mainline

Your commit was automatically rebased without conflicts.

Pushed as commit ac68edf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant