Skip to content

Conversation

@Arraying
Copy link
Member

@Arraying Arraying commented Sep 23, 2025

Hi all,

There's been quite a lot of noise regarding timeout failures in the ConcurrentClassLoadingTest. This patch reduces the iterations.

Tests: 25 repetitions of the test on all platforms.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8368371: runtime/valhalla/inlinetypes/classloading/ConcurrentClassLoadingTest.java timeouts (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1611/head:pull/1611
$ git checkout pull/1611

Update a local copy of the PR:
$ git checkout pull/1611
$ git pull https://git.openjdk.org/valhalla.git pull/1611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1611

View PR using the GUI difftool:
$ git pr show -t 1611

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1611.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368371: runtime/valhalla/inlinetypes/classloading/ConcurrentClassLoadingTest.java timeouts

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8368371 8368371: runtime/valhalla/inlinetypes/classloading/ConcurrentClassLoadingTest.java timeouts Sep 23, 2025
@Arraying Arraying marked this pull request as ready for review September 23, 2025 08:14
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2025
Copy link
Member

@MrSimms MrSimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@Arraying
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@Arraying
Your change (at version fa7726d) is now ready to be sponsored by a Committer.

@MrSimms
Copy link
Member

MrSimms commented Sep 23, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

Going to push as commit cb4da36.
Since your change was applied there have been 82 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2025
@openjdk openjdk bot closed this Sep 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@MrSimms @Arraying Pushed as commit cb4da36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants