8252299: [lworld] C2 compilation fails with assert(!use_ReduceInitialCardMarks()) failed: can only happen with card marking #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When replacing an inline type buffer allocation by a dominating allocation, we are removing stores and re-link all users of the dominated allocation to the dominating one (see InlineTypeNode::replace_allocation). Now we forgot to also remove GC barriers for initializing stores to the dominated allocation, which causes several issues because these are then re-linked to the dominated allocation as well while the corresponding stores were removed. The fix is to simply remove these barriers as well via BarrierSet::eliminate_gc_barrier.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/166/head:pull/166
$ git checkout pull/166