Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252299: [lworld] C2 compilation fails with assert(!use_ReduceInitialCardMarks()) failed: can only happen with card marking #166

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 25, 2020

When replacing an inline type buffer allocation by a dominating allocation, we are removing stores and re-link all users of the dominated allocation to the dominating one (see InlineTypeNode::replace_allocation). Now we forgot to also remove GC barriers for initializing stores to the dominated allocation, which causes several issues because these are then re-linked to the dominated allocation as well while the corresponding stores were removed. The fix is to simply remove these barriers as well via BarrierSet::eliminate_gc_barrier.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252299: [lworld] C2 compilation fails with assert(!use_ReduceInitialCardMarks()) failed: can only happen with card marking

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/166/head:pull/166
$ git checkout pull/166

…lCardMarks()) failed: can only happen with card marking
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 25, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252299: [lworld] C2 compilation fails with assert(!use_ReduceInitialCardMarks()) failed: can only happen with card marking
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the lworld branch:

  • acfed88: 8252061: [lword] Support Object::toString for inline type
  • bce51c9: 8244713: [lworld] V.ref class should not inadvertently carry over attributes from V.class

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate acfed88167d4f6228802af8fcffdd54b58817689.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 25, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 26, 2020

/integrate

@openjdk openjdk bot closed this Aug 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2020

@TobiHartmann The following commits have been pushed to lworld since your change was applied:

  • acfed88: 8252061: [lword] Support Object::toString for inline type
  • bce51c9: 8244713: [lworld] V.ref class should not inadvertently carry over attributes from V.class

Your commit was automatically rebased without conflicts.

Pushed as commit 54b5410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant