Skip to content

Conversation

@matias9927
Copy link
Contributor

@matias9927 matias9927 commented Oct 6, 2025

The --enable-preview was not propagated correctly to the sub-process used in this test so this option was added explicitly.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8369066: [lworld] UncaughtNativeExceptionTest.java fails with UnsupportedClassVersionError (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1663/head:pull/1663
$ git checkout pull/1663

Update a local copy of the PR:
$ git checkout pull/1663
$ git pull https://git.openjdk.org/valhalla.git pull/1663/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1663

View PR using the GUI difftool:
$ git pr show -t 1663

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1663.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2025

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369066: [lworld] UncaughtNativeExceptionTest.java fails with UnsupportedClassVersionError

Reviewed-by: dsimms, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 296 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2025

Webrevs

@matias9927
Copy link
Contributor Author

Thank you for the reviews @MrSimms and @RogerRiggs
/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

Going to push as commit a592447.
Since your change was applied there have been 296 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025
@openjdk openjdk bot closed this Oct 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@matias9927 Pushed as commit a592447.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants