Skip to content

Conversation

@matias9927
Copy link
Contributor

@matias9927 matias9927 commented Oct 8, 2025

This test fails with -XX:AOTClassLinking but the failure should no longer occur after upstreaming JDK-8364929. This test should be problem listed for now.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8369446: [lworld] Problem list LoggingDeadlock2 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1668/head:pull/1668
$ git checkout pull/1668

Update a local copy of the PR:
$ git checkout pull/1668
$ git pull https://git.openjdk.org/valhalla.git pull/1668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1668

View PR using the GUI difftool:
$ git pr show -t 1668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1668.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2025

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369446: [lworld] Problem list LoggingDeadlock2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2025

Webrevs

@matias9927
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

Going to push as commit 693a507.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • dd39de4: 8368795: [lworld] javac rejects assignments to components of array fields with initializers in the prologue

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2025
@openjdk openjdk bot closed this Oct 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2025
@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@matias9927 Pushed as commit 693a507.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant