-
Notifications
You must be signed in to change notification settings - Fork 143
8370263: [lworld] Fix compile commands after JDK-8369437 #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * -Xbatch -XX:-TieredCompilation | ||
| * -XX:CompileCommand=dontinline,TestOopsInReturnConvention::callee | ||
| * -XX:CompileCommand=dontinline,TestOopsInReturnConvention*::verify | ||
| * -XX:CompileCommand=dontinline,*TestOopsInReturnConvention*::callee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the * after TestOopsInReturnConvention was missing before: callee() is only defined in the inner class LargeValueWithOops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
| * -XX:CompileCommand=compileonly,TestUnloadedInlineTypeArray::test* | ||
| * TestUnloadedInlineTypeArray | ||
| * -XX:CompileCommand=compileonly,*TestUnloadedInlineTypeArray::test* | ||
| * compiler.valhalla.inlinetypes.TestUnloadedInlineTypeArray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing package - forgot to do in JDK-8369437.
|
👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into |
|
@chhagedorn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
TobiHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks Tobias! /integrate |
|
Going to push as commit 1900317.
Your commit was automatically rebased without conflicts. |
|
@chhagedorn Pushed as commit 1900317. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When adding packages in JDK-8369437, some compile commands were not updated accordingly as well. This is fixes with this patch.
Thanks,
Christian
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1689/head:pull/1689$ git checkout pull/1689Update a local copy of the PR:
$ git checkout pull/1689$ git pull https://git.openjdk.org/valhalla.git pull/1689/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1689View PR using the GUI difftool:
$ git pr show -t 1689Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1689.diff
Using Webrev
Link to Webrev Comment