Skip to content

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Oct 21, 2025

When adding packages in JDK-8369437, some compile commands were not updated accordingly as well. This is fixes with this patch.

Thanks,
Christian


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8370263: [lworld] Fix compile commands after JDK-8369437 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1689/head:pull/1689
$ git checkout pull/1689

Update a local copy of the PR:
$ git checkout pull/1689
$ git pull https://git.openjdk.org/valhalla.git pull/1689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1689

View PR using the GUI difftool:
$ git pr show -t 1689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1689.diff

Using Webrev

Link to Webrev Comment

* -Xbatch -XX:-TieredCompilation
* -XX:CompileCommand=dontinline,TestOopsInReturnConvention::callee
* -XX:CompileCommand=dontinline,TestOopsInReturnConvention*::verify
* -XX:CompileCommand=dontinline,*TestOopsInReturnConvention*::callee
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the * after TestOopsInReturnConvention was missing before: callee() is only defined in the inner class LargeValueWithOops.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

* -XX:CompileCommand=compileonly,TestUnloadedInlineTypeArray::test*
* TestUnloadedInlineTypeArray
* -XX:CompileCommand=compileonly,*TestUnloadedInlineTypeArray::test*
* compiler.valhalla.inlinetypes.TestUnloadedInlineTypeArray
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing package - forgot to do in JDK-8369437.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2025

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370263: [lworld] Fix compile commands after JDK-8369437

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • b5e30d5: 8369134: [lworld] We should preserve the markWord for all GCs
  • 204f803: 8369860: [lworld] Javac generates duplicate initializer code

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2025

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chhagedorn
Copy link
Member Author

Thanks Tobias!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

Going to push as commit 1900317.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • b5e30d5: 8369134: [lworld] We should preserve the markWord for all GCs
  • 204f803: 8369860: [lworld] Javac generates duplicate initializer code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2025
@openjdk openjdk bot closed this Oct 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@chhagedorn Pushed as commit 1900317.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants