Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242455: [lworld] C1 compilation fails with assert "should have same type" #17

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 9, 2020

Merge from mainline accidentally reverted the fix for JDK-8237894.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242455: [lworld] C1 compilation fails with assert "should have same type"

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/17/head:pull/17
$ git checkout pull/17

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242455: [lworld] C1 compilation fails with assert "should have same type"
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Apr 9, 2020

/integrate

@openjdk openjdk bot closed this Apr 9, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2020

@TobiHartmann
Pushed as commit d87d47d.

@openjdk openjdk bot removed the rfr label Apr 9, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant