8371398: [lworld] runtime/valhalla/inlinetypes/FlatArrayCopyingTest.java#g1 fails due to lack of UnlockDiagnosticVMOptions

[Arraying]

Hi all,

The flag UnlockDiagnosticVMOptions should be set explicitly.

Tests: tier 1, tier 5.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8371398: [lworld] runtime/valhalla/inlinetypes/FlatArrayCopyingTest.java#g1 fails due to lack of UnlockDiagnosticVMOptions (Bug - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1726/head:pull/1726
$ git checkout pull/1726

Update a local copy of the PR:
$ git checkout pull/1726
$ git pull https://git.openjdk.org/valhalla.git pull/1726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1726

View PR using the GUI difftool:
$ git pr show -t 1726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1726.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371398: [lworld] runtime/valhalla/inlinetypes/FlatArrayCopyingTest.java#g1 fails due to lack of UnlockDiagnosticVMOptions

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

• 296fe86: 8341771: [lworld] Heap dump recognizing new flat fields formats
• a0ec244: 8367244: [lworld] C2 compilation fails with assert "no node with a side effect"

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (ba4fb988)
• 00: Full (2753e2fb)

[Arraying]

Thanks for the review, Fred.

/integrate

[MrSimms]

/sponsor

[openjdk]

@Arraying
Your change (at version ba4fb98) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit a180fef.
Since your change was applied there have been 2 commits pushed to the lworld branch:

• 296fe86: 8341771: [lworld] Heap dump recognizing new flat fields formats
• a0ec244: 8367244: [lworld] C2 compilation fails with assert "no node with a side effect"

Your commit was automatically rebased without conflicts.

[openjdk]

@MrSimms @Arraying Pushed as commit a180fef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.