8370634: [lworld] super should not be allowed in compact constructors

[vicente-romero-oracle]

there is a bug in lworld and due to it javac accepts records with compact constructors that contain invocations to the super constructor. This is not allowed by the spec. This PR is fixing this issue,

TIA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8370634: [lworld] super should not be allowed in compact constructors (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1770/head:pull/1770
$ git checkout pull/1770

Update a local copy of the PR:
$ git checkout pull/1770
$ git pull https://git.openjdk.org/valhalla.git pull/1770/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1770

View PR using the GUI difftool:
$ git pr show -t 1770

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1770.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370634: [lworld] super should not be allowed in compact constructors

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (1ac8c5da)
• 01: Full - Incremental (a6c7a537)
• 00: Full (6d36b2aa)

[liach]

I recommend adding a positive test to ensure a normal canonical constructor of a record can call super as well.

[vicente-romero-oracle]

@liach done, thanks for the review

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 36f43f7.

[openjdk]

@vicente-romero-oracle Pushed as commit 36f43f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.