Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252753: [lworld] Merge of jdk-16+12 broke CDS for inline types #179

Closed
wants to merge 1 commit into from

Conversation

iklam
Copy link
Member

@iklam iklam commented Sep 6, 2020

This fixes handling of inline types by CDS -- implemented handling of MetaspaceClosure::_internal_pointer_ref


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252753: [lworld] Merge of jdk-16+12 broke CDS for inline types

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/179/head:pull/179
$ git checkout pull/179

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 6, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@iklam
Copy link
Member Author

@iklam iklam commented Sep 6, 2020

/summary implemented handling of MetaspaceClosure::_internal_pointer_ref

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iklam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252753: [lworld] Merge of jdk-16+12 broke CDS for inline types

implemented handling of MetaspaceClosure::_internal_pointer_ref

Reviewed-by: dsimms
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 40f856832c3a33c37c0be346d283102fbe2c8c4e.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iklam Setting summary to implemented handling of MetaspaceClosure::_internal_pointer_ref

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 6, 2020

Webrevs

MrSimms
MrSimms approved these changes Sep 6, 2020
Copy link
Member

@MrSimms MrSimms left a comment

Looks good, assume the commented tty print lines will either disappear later or be debug log ?

@iklam
Copy link
Member Author

@iklam iklam commented Sep 6, 2020

Oops, I amended the commit and removed the print_cr.

@iklam
Copy link
Member Author

@iklam iklam commented Sep 6, 2020

/integrate

@openjdk openjdk bot closed this Sep 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iklam Pushed as commit 9616df9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants