Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252854: [lworld] Buffering in C1 entry can trigger safepoint before nmethod entry barrier has been executed #180

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 7, 2020

The runtime call to buffer scalarized inline type arguments in the C1 entry points can safepoint before the entry barrier of the corresponding nmethod has been executed. As a result, oops in the nmethod might be bad and the GC crashes in 'nmethod_oops_do'. We should simply execute the entry barrier before calling into the runtime.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252854: [lworld] Buffering in C1 entry can trigger safepoint before nmethod entry barrier has been executed

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/180/head:pull/180
$ git checkout pull/180

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252854: [lworld] Buffering in C1 entry can trigger safepoint before nmethod entry barrier has been executed
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 9616df9950c48b175a8797aadd310f64bdc7eb77.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 7, 2020

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@TobiHartmann Pushed as commit 963ed68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant