8253218 ClassFileParser hits assert(klass->access_flags().is_inline_t… #191
Conversation
…ype()) failed: Value type expected
|
|
|
@hseigel This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
Webrevs
|
| @@ -5299,6 +5299,9 @@ void ClassFileParser::verify_legal_field_signature(const Symbol* name, | |||
| const Symbol* signature, | |||
| TRAPS) const { | |||
| if (!_need_verify) { return; } | |||
| if (!supports_inline_types() && signature->is_Q_signature()) { | |||
There was a problem hiding this comment.
Shouldn't the test also include a check for Q-arrays? (signature->is_Q_array_signature()) ?
There was a problem hiding this comment.
Yes, it should check for Q-arrays. I'll add the check. Thanks!
…ype()) failed: Value type expected
|
/integrate |
|
@hseigel Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4f9c2e2. |
Please review this fix for JDK-8253218. The fix throws a ClassFormatError exception if a class file, with an old class file version, contains a Q signature.
The fix was tested with tiers 1-2 on Windows, Linux x64, and MacOS, and tiers 3-5 on Linux x64.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/191/head:pull/191$ git checkout pull/191