Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253218 ClassFileParser hits assert(klass->access_flags().is_inline_t… #191

Closed
wants to merge 2 commits into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Sep 16, 2020

Please review this fix for JDK-8253218. The fix throws a ClassFormatError exception if a class file, with an old class file version, contains a Q signature.

The fix was tested with tiers 1-2 on Windows, Linux x64, and MacOS, and tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8253218: [lworld] ClassFileParser hits assert(klass->access_flags().is_inline_type()) failed: Value type expected ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/191/head:pull/191
$ git checkout pull/191

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@hseigel This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253218: ClassFileParser hits assert(klass->access_flags().is_inline_t…

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • 174dcf5: 8253143: [lworld] Valhalla microbenchmarks bulk update

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 174dcf50d20057388430e7e0828c27ee05cb3d6c.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2020

Webrevs

@@ -5299,6 +5299,9 @@ void ClassFileParser::verify_legal_field_signature(const Symbol* name,
const Symbol* signature,
TRAPS) const {
if (!_need_verify) { return; }
if (!supports_inline_types() && signature->is_Q_signature()) {
Copy link
Collaborator

@fparain fparain Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the test also include a check for Q-arrays? (signature->is_Q_array_signature()) ?

Copy link
Member Author

@hseigel hseigel Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should check for Q-arrays. I'll add the check. Thanks!

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@hseigel
Copy link
Member Author

@hseigel hseigel commented Sep 17, 2020

/integrate

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@hseigel Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 174dcf5: 8253143: [lworld] Valhalla microbenchmarks bulk update

Your commit was automatically rebased without conflicts.

Pushed as commit 4f9c2e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants