Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253592: [lworld] C2: Additional fixes for handling empty inline types #197

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 24, 2020

While working on JDK-8253416, I found more issues with handling of empty inline types in C2:

  • Compile::build_start_state assumes that all inline type arguments are scalarized if has_scalarized_args() is true but one of the arguments could be non-scalarized (for example, if it's an empty inline type).
  • Loads/stores from/to inline type fields should be removed. Refactoring the related code also fixes an issue where alias analysis gets confused when looking at flattened fields of empty inline types.

Unrelated fixes:

  • Handling of unexpected inline/non-inline klasses in _new/_defaultvalue.
  • Missing @DontCompile statements in some tests

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8253592: [lworld] C2: Additional fixes for handling empty inline types

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/197/head:pull/197
$ git checkout pull/197

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253592: [lworld] C2: Additional fixes for handling empty inline types

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Sep 24, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 24, 2020

/integrate

@openjdk openjdk bot closed this Sep 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2020
@openjdk
Copy link

openjdk bot commented Sep 24, 2020

@TobiHartmann Since your change was applied there have been 86 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 33bdce2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant