Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IdentityObject.newIdentity() #2

Closed
wants to merge 2 commits into from

Conversation

@RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Mar 20, 2020

Switching to the Skara infra for the GitHub based Valhalla lworld branch...

Following the discussion on valhalla-dev
https://mail.openjdk.java.net/pipermail/valhalla-dev/2020-March/006867.html

Please review and comment.


Progress

  • Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/2/head:pull/2
$ git checkout pull/2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 20, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 20, 2020

@RogerRiggs This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Added IdentityObject.newIdentity()
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 20, 2020

Webrevs

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Mar 24, 2020

/solves JDK-8239929
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2020

@RogerRiggs Could not find issue JDK-8239929 in the list of additional solved issues.

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Mar 24, 2020

/solves 8239929
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2020

@RogerRiggs Could not find issue 8239929 in the list of additional solved issues.

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Mar 24, 2020

/integrate

@openjdk openjdk bot closed this Mar 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2020

@RogerRiggs
Pushed as commit 0bca291.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2020

Mailing list message from Roger Riggs on valhalla-dev:

Changeset: 0bca291
Author: Roger Riggs <rriggs at openjdk.org>
Date: 2020-03-24 14:18:52 +0000
URL: https://git.openjdk.java.net/valhalla/commit/0bca2918

Added IdentityObject.newIdentity()

! src/java.base/share/classes/java/lang/Object.java
! src/java.base/share/classes/java/util/Objects.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant