Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242269: [lworld] C2 compilation fails with assert "meet not symmetric" #20

Closed
wants to merge 1 commit into from

Conversation

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Apr 9, 2020

This tweaks the type system to fix error triggered by the recent merge.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242269: [lworld] C2 compilation fails with assert "meet not symmetric"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/20/head:pull/20
$ git checkout pull/20

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2020

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2020

@rwestrel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242269: [lworld] C2 compilation fails with assert "meet not symmetric"

Reviewed-by: dsimms, thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the lworld branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate acffd197fa1749c3e867073cc8ddf6c48b9fcb7d.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2020

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Tested, works fine. Tobias talked last week about a fix from you Roland. Thanks for cleaning up.

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Apr 15, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2020

@MrSimms Only the author (@rwestrel) is allowed to issue the integrate command.

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Apr 15, 2020

Hit integrate if you are done (Tobias is out this week I think, if you were waiting on him)

@rwestrel
Copy link
Collaborator Author

@rwestrel rwestrel commented Apr 15, 2020

I'd like Tobias to take a look at this. Integrating this is not urgent. Tobias disabled the new verification code that triggered the failures. This fixes the failures that that verification code uncovered. They are not new failures. We were just unaware of them.

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Apr 15, 2020

I'd like Tobias to take a look at this. Integrating this is not urgent.

Fair enough, thank you !

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me!

@rwestrel
Copy link
Collaborator Author

@rwestrel rwestrel commented Apr 20, 2020

/integrate

@openjdk openjdk bot closed this Apr 20, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2020

@rwestrel The following commits have been pushed to lworld since your change was applied:

  • acffd19: 8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate
  • aee9550: Change exception messages to say 'Inline type' instead of 'Value type'

Your commit was automatically rebased without conflicts.

Pushed as commit ff1b435.

@openjdk openjdk bot removed the rfr label Apr 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2020

Mailing list message from Roland Westrelin on valhalla-dev:

Changeset: ff1b435
Author: Roland Westrelin <roland at openjdk.org>
Date: 2020-04-20 08:32:28 +0000
URL: https://git.openjdk.java.net/valhalla/commit/ff1b435e

8242269: [lworld] C2 compilation fails with assert "meet not symmetric"

Reviewed-by: dsimms, thartmann

! src/hotspot/share/opto/type.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants