Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253663: [lworld] [lw3] TestJNIArrays crashes in jni_CreateSubElementSelector #200

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Sep 28, 2020

Please review this small changeset fixing two naked oops in the JNI code to access flattened arrays.
These fixes should prevent the crashes we recently saw with TestJNIArrays test.

Tested with Mach5, tiers 1 to 3.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8253663: [lworld] [lw3] TestJNIArrays crashes in jni_CreateSubElementSelector

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/200/head:pull/200
$ git checkout pull/200

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 28, 2020

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253663: [lworld] [lw3] TestJNIArrays crashes in jni_CreateSubElementSelector

Reviewed-by: lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Sep 28, 2020

Webrevs

Copy link
Member

@lfoltan lfoltan left a comment

Looks good.

@fparain
Copy link
Collaborator Author

fparain commented Sep 28, 2020

Lois,

Thank you for your review,

Fred

@fparain
Copy link
Collaborator Author

fparain commented Sep 28, 2020

/integrate

@openjdk openjdk bot closed this Sep 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 28, 2020
@openjdk
Copy link

openjdk bot commented Sep 28, 2020

@fparain Pushed as commit e605c42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the test_jni_arrays branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants