Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate #21

Closed
wants to merge 2 commits into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented Apr 10, 2020

The new and defaultvalue bytecodes currently lack a check to ensure that the class to instantiate is of the right kind.

These changes add checks in both slow and fast path of the interpreter.

Testing:

  • unit test added
  • mach5 tier 1 (all failures were pre-existing)

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate

Reviewers

  • David Simms (dsimms - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/21/head:pull/21
$ git checkout pull/21

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 10, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 10, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate

Reviewed-by: dsimms
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate aee9550ce333f2fad053d8748aa1be27338bd92f.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@fparain fparain changed the title 8242496 [lworld] new and defaultvalue don't perform checks on class to instantiate 8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate Apr 10, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 10, 2020

Webrevs

@MrSimms MrSimms self-requested a review Apr 14, 2020
Copy link
Member

@MrSimms MrSimms left a comment

Looks good !

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2020

Mailing list message from Frederic Parain on valhalla-dev:

Thank you David.

Fred

On Apr 14, 2020, at 08:45, David Simms <dsimms at openjdk.java.net> wrote:

On Fri, 10 Apr 2020 16:37:27 GMT, Frederic Parain <fparain at openjdk.org> wrote:

The new and defaultvalue bytecodes currently lack a check to ensure that the class to instantiate is of the right kind.

These changes add checks in both slow and fast path of the interpreter.

Testing:
- unit test added
- mach5 tier 1 (all failures were pre-existing)

Looks good !

Marked as reviewed by dsimms (Committer).

-------------

PR: https://git.openjdk.java.net/valhalla/pull/21

@fparain
Copy link
Collaborator Author

@fparain fparain commented Apr 14, 2020

/integrate

@openjdk openjdk bot closed this Apr 14, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2020

@fparain The following commits have been pushed to lworld since your change was applied:

  • aee9550: Change exception messages to say 'Inline type' instead of 'Value type'

Your commit was automatically rebased without conflicts.

Pushed as commit acffd19.

@openjdk openjdk bot removed the rfr label Apr 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2020

Mailing list message from Frederic Parain on valhalla-dev:

Changeset: acffd19
Author: Frederic Parain <fparain at openjdk.org>
Date: 2020-04-14 13:33:55 +0000
URL: https://git.openjdk.java.net/valhalla/commit/acffd197

8242496: [lworld] new and defaultvalue don't perform checks on class to instantiate

Reviewed-by: dsimms

! src/hotspot/cpu/x86/templateTable_x86.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/interpreter/interpreterRuntime.hpp
! src/hotspot/share/oops/instanceKlass.hpp
+ test/hotspot/jtreg/runtime/valhalla/valuetypes/CreationErrorTest.java

@fparain fparain deleted the creation_check branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants