Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254957: Comparison of ArrayList with int, Integer, PrimitiveInt,... #229

Closed
wants to merge 6 commits into from

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Oct 17, 2020

Prototypes and JMH benchmarks to compare possible implementations of ArrayListInt, ArrayListPrimitiveInt with ArrayList and ArrayList.

Located in .../test/micro/org/openjdk/bench/valhalla/sandbox/corelibs/...


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (5/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8254957: Comparison of ArrayList with int, Integer, PrimitiveInt,...

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/229/head:pull/229
$ git checkout pull/229

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 17, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 17, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254957: Comparison of ArrayList with int, Integer, PrimitiveInt,...

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 17, 2020

Webrevs

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Oct 19, 2020

/integrate

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Oct 19, 2020

A sample set of benchmark scores.

ArrayListOfIntBench.appendListInt                 100  avgt    5       0.190 ±    0.031  us/op
ArrayListOfIntBench.appendListOfInteger           100  avgt    5       0.507 ±    0.053  us/op
ArrayListOfIntBench.appendListOfPrimitiveInt      100  avgt    5       0.552 ±    0.088  us/op
ArrayListOfIntBench.appendListPrimitiveInt        100  avgt    5       0.188 ±    0.032  us/op
ArrayListOfIntBench.sumListInt                    100  avgt    5       0.040 ±    0.001  us/op
ArrayListOfIntBench.sumListOfInteger              100  avgt    5       0.093 ±    0.005  us/op
ArrayListOfIntBench.sumListOfPrimitiveInt         100  avgt    5       0.092 ±    0.003  us/op
ArrayListOfIntBench.sumListPrimitiveInt           100  avgt    5       0.038 ±    0.002  us/op
ArrayListOfIntBench.thrashListInt                 100  avgt    5      27.725 ±    1.160  us/op
ArrayListOfIntBench.thrashListOfInteger           100  avgt    5      34.020 ±    0.350  us/op
ArrayListOfIntBench.thrashListOfPrimitiveInt      100  avgt    5      55.849 ±    5.382  us/op
ArrayListOfIntBench.thrashListPrimitiveInt        100  avgt    5      42.042 ±    0.673  us/op
ArrayListOfIntBench.appendListInt             1000000  avgt    5    2314.797 ±  725.937  us/op
ArrayListOfIntBench.appendListOfInteger       1000000  avgt    5    7057.021 ± 1370.781  us/op
ArrayListOfIntBench.appendListOfPrimitiveInt  1000000  avgt    5    7143.504 ± 2125.302  us/op
ArrayListOfIntBench.appendListPrimitiveInt    1000000  avgt    5    2146.208 ±  382.608  us/op
ArrayListOfIntBench.sumListInt                1000000  avgt    5     345.963 ±    5.328  us/op
ArrayListOfIntBench.sumListOfInteger          1000000  avgt    5    1743.291 ± 1454.943  us/op
ArrayListOfIntBench.sumListOfPrimitiveInt     1000000  avgt    5    1405.064 ±   32.415  us/op
ArrayListOfIntBench.sumListPrimitiveInt       1000000  avgt    5     341.422 ±    8.290  us/op
ArrayListOfIntBench.thrashListInt             1000000  avgt    5   56875.384 ± 1446.936  us/op
ArrayListOfIntBench.thrashListOfInteger       1000000  avgt    5   58388.353 ± 3004.966  us/op
ArrayListOfIntBench.thrashListOfPrimitiveInt  1000000  avgt    5  116907.473 ± 1190.818  us/op
ArrayListOfIntBench.thrashListPrimitiveInt    1000000  avgt    5  113999.171 ± 7173.833  us/op

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@RogerRiggs Pushed as commit 28fb33d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant