Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254797: [Development] Define & apply annotation jdk.internal.ValueBased #233

wants to merge 3 commits into from


Copy link

@RogerRiggs RogerRiggs commented Oct 20, 2020

Define a JDK-internal annotation, jdk.internal.ValueBased, which indicates that a class or interface is value-based, per: java/lang/doc-files/ValueBased.html

(The switch of the compiler from the existing java.lang.ValueBased to jdk.internal.ValueBased will occur separately).

Apply the annotation wherever existing documentation references ValueBased.html, including:

  • The primitive wrapper classes in java.lang;
  • The class java.lang.Runtime.Version;
  • The "optional" classes in java.util: Optional, OptionalInt, OptionalLong, and OptionalDouble;
  • Many classes in the java.time API: Instant, LocalDate, LocalTime, LocalDateTime, ZonedDateTime, ZoneId, OffsetTime, OffsetDateTime, ZoneOffset, Duration, Period, Year, YearMonth, and MonthDay, and, in java.time.chrono: MinguoDate, HijrahDate, JapaneseDate, and ThaiBuddhistDate;
  • The interface java.lang.ProcessHandle and its implementation classes;
  • and an initial set of other classes

The CSR for these changes will occur after the prototyping of javac and the VM runtime is working.


  • Change must not contain extraneous whitespace


Linux x64 Windows x64 macOS x64
Build (2/5 failed) (2/2 failed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed)

Failed test tasks


  • JDK-8254797: [Development] Define & apply annotation jdk.internal.ValueBased


$ git fetch pull/233/head:pull/233
$ git checkout pull/233

Copy link

bridgekeeper bot commented Oct 20, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

openjdk bot commented Oct 20, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8254797: [Development] Define & apply annotation jdk.internal.ValueBased

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 28b90dc: 8255054: Fix test broken by incorrect removal of java.lang.ValueBased

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

Copy link

openjdk bot commented Oct 20, 2020

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Copy link

mlbridge bot commented Oct 20, 2020


Copy link
Collaborator Author


@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2020
Copy link

openjdk bot commented Oct 20, 2020

@RogerRiggs Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 28b90dc: 8255054: Fix test broken by incorrect removal of java.lang.ValueBased

Your commit was automatically rebased without conflicts.

Pushed as commit 3167856.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link

mlbridge bot commented Oct 21, 2020

Mailing list message from Srikanth on valhalla-dev:


May be I have understood the process wrong - Should this change have
been integrated into lworld branch ??
I thought JEP390 branch on valhalla was supposed to host all the changes
pertinent to JEP390 and that these
would make it to lworld only via a merge from jdk/jdk after they make it
to there from jep390 branch.

Thanks in advance for clarifying the process to be followed.

On 21/10/20 1:52 am, Roger Riggs wrote:

Copy link

mlchung commented Oct 21, 2020

Looks like Roger pushed to the wrong branch. It's supposed to push to jep390 branch.

Copy link
Collaborator Author

Yep, I didn't change the pull-down when creating the PR.
Please review... #235

@RogerRiggs RogerRiggs deleted the value-based-8254797 branch October 30, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants