Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255125: [Development] copy jdk.internal.ValueBased to jep390 branch #235

wants to merge 1 commit into from


Copy link

@RogerRiggs RogerRiggs commented Oct 21, 2020

Commit a copy of the and its uses to the JEP 390 branch.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)


  • JDK-8255125: [Development] copy jdk.internal.ValueBased to jep390 branch



$ git fetch pull/235/head:pull/235
$ git checkout pull/235

Copy link

bridgekeeper bot commented Oct 21, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into jep390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 21, 2020
Copy link

mlbridge bot commented Oct 21, 2020


Copy link
Collaborator Author


Copy link

openjdk bot commented Oct 21, 2020

@RogerRiggs This PR has not yet been marked as ready for integration.

Copy link

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial patch looks okay that will allow javac and VM change to proceed.

Copy link

openjdk bot commented Oct 21, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8255125: [Development] copy jdk.internal.ValueBased to jep390 branch

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jep390 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep390 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 21, 2020
Copy link
Collaborator Author


@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2020
Copy link

openjdk bot commented Oct 21, 2020

@RogerRiggs Pushed as commit f2f03c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the value-based-8255125 branch January 11, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants