Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255733: [type-restrictions] Enhance Javac to help with generation of test files for type restrictions experiments #251

Closed

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Nov 2, 2020

Added option -XDflattenWithErasure to generate class files without the RestrictedField attribute


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (4/4 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255733: [type-restrictions] Enhance Javac to help with generation of test files for type restrictions experiments

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/251/head:pull/251
$ git checkout pull/251

… test files for type restrictions experiments

    Added a new option -XDflattenWithErasure to generate class files without RestrictedField attribute
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 2, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into type-restrictions will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255733: [type-restrictions] Enhance Javac to help with generation of test files for type restrictions experiments

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the type-restrictions branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-restrictions branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 2, 2020

Webrevs

@sadayapalam sadayapalam deleted the JDK-8255733 branch Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant