Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238369: [lworld] Incorrect layout of inline type in flattened array. #265

Closed
wants to merge 2 commits into from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Nov 17, 2020

Removed obsolete and incorrect raw_value_byte_size


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (3/4 running) (2/2 running) (2/2 running)

Issue

  • JDK-8238369: [lworld] Incorrect layout of inline type in flattened array.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/265/head:pull/265
$ git checkout pull/265

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 17, 2020
@MrSimms MrSimms changed the title 8238369: [lworld] Incorrect layout of inline type in flattened array 8238369: [lworld] Incorrect layout of inline type in flattened array. Nov 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8238369: [lworld] Incorrect layout of inline type in flattened array.

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 928c29e: Disable further BiasedLocking tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.
Thank you for the additional tests.

Fred

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Nov 17, 2020

/integrate

@openjdk openjdk bot closed this Nov 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@MrSimms Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 928c29e: Disable further BiasedLocking tests

Your commit was automatically rebased without conflicts.

Pushed as commit cc1f08e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8238369 branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants