Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255995: templateTable_x86.cpp (TemplateTable::if_acmp) not always do correct null check. #266

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Nov 17, 2020

Testing both pointers at the same time, doesn't account for the case where bits
completely miss each other, resulting in zero as result e.g.

test(0x10, 0x01) == 0x10 & 0x01 == 0, yet neither are null


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (4/4 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255995: templateTable_x86.cpp (TemplateTable::if_acmp) not always do correct null check.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/266/head:pull/266
$ git checkout pull/266

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255995: templateTable_x86.cpp (TemplateTable::if_acmp) not always do correct null check.

Reviewed-by: fparain, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

LGTM

Fred

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Nov 18, 2020

/integrate

@openjdk openjdk bot closed this Nov 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2020

@MrSimms Pushed as commit e9217da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8255995 branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants