8253962: Add @ValueBased to unmodifable Collection implementation classes

[RogerRiggs]

As per JEP 390, The implementations of ImmutableCollections are marked as being @valuebased.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	❌ (1/9 failed)	❌ (1/9 failed)	❌ (1/9 failed)

Failed test tasks

• Linux x64 (langtools/tier1)
• Windows x64 (langtools/tier1)
• macOS x64 (langtools/tier1)

Issue

• JDK-8253962: Add @valuebased to unmodifable Collection implementation classes

Reviewers

• Mandy Chung (@mlchung - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/267/head:pull/267
$ git checkout pull/267

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into jep390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (b6d8817)
• 00: Full (d289156)

[openjdk]

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253962: Add @ValueBased to unmodifable Collection implementation classes

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 564 new commits pushed to the jep390 branch:

• c6385a2: 8256002: Cleanup of Wrapper changes
• de62f4e: Merge
• bfa060f: 8256051: nmethod_entry_barrier stub miscalculates xmm spill size on x86_32
• 96e0261: 8256106: Bypass intrinsic/barrier when calling Reference.get() from Finalizer
• 3c3469b: 8256020: Shenandoah: Don't resurrect objects during evacuation on AS_NO_KEEPALIVE
• 2e19026: 8253064: monitor list simplifications and getting rid of TSM
• 421a7c3: 8256182: Update qemu-debootstrap cross-compilation recipe
• 6247736: 8256018: Adler32/CRC32/CRC32C missing reachabilityFence
• 436019b: 8256166: [C2] Registers get confused on Big Endian after 8221404
• ed615e3: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper
• ... and 554 more: https://git.openjdk.java.net/valhalla/compare/0c2ef39c2ae1632ddb77f0475dff89004825110c...jep390

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep390 branch, type /integrate in a new comment.

[RogerRiggs]

/integrate

[openjdk]

@RogerRiggs Since your change was applied there have been 564 commits pushed to the jep390 branch:

• c6385a2: 8256002: Cleanup of Wrapper changes
• de62f4e: Merge
• bfa060f: 8256051: nmethod_entry_barrier stub miscalculates xmm spill size on x86_32
• 96e0261: 8256106: Bypass intrinsic/barrier when calling Reference.get() from Finalizer
• 3c3469b: 8256020: Shenandoah: Don't resurrect objects during evacuation on AS_NO_KEEPALIVE
• 2e19026: 8253064: monitor list simplifications and getting rid of TSM
• 421a7c3: 8256182: Update qemu-debootstrap cross-compilation recipe
• 6247736: 8256018: Adler32/CRC32/CRC32C missing reachabilityFence
• 436019b: 8256166: [C2] Registers get confused on Big Endian after 8221404
• ed615e3: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper
• ... and 554 more: https://git.openjdk.java.net/valhalla/compare/0c2ef39c2ae1632ddb77f0475dff89004825110c...jep390

Your commit was automatically rebased without conflicts.

Pushed as commit 12f93eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.