Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253962: Add @ValueBased to unmodifable Collection implementation classes #267

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Nov 17, 2020

As per JEP 390, The implementations of ImmutableCollections are marked as being @valuebased.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) (1/9 failed) (1/9 failed)

Failed test tasks

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/267/head:pull/267
$ git checkout pull/267

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into jep390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 17, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 17, 2020

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Nov 18, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253962: Add @ValueBased to unmodifable Collection implementation classes

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 564 new commits pushed to the jep390 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep390 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 18, 2020
@RogerRiggs
Copy link
Collaborator Author

RogerRiggs commented Nov 19, 2020

/integrate

@openjdk openjdk bot closed this Nov 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 19, 2020
@openjdk
Copy link

openjdk bot commented Nov 19, 2020

@RogerRiggs Since your change was applied there have been 564 commits pushed to the jep390 branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 12f93eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the valuebased-collections-8253962 branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants