Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256929: [lworld] Fails to compile with --with-debug-level=optimized #276

Closed
wants to merge 1 commit into from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Nov 24, 2020

Guard use of debug "valid_itable_index()" assert macro


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (5/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8256929: [lworld] Fails to compile with --with-debug-level=optimized

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/276/head:pull/276
$ git checkout pull/276

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2020

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256929: [lworld] Fails to compile with --with-debug-level=optimized

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@MrSimms
Copy link
Member Author

MrSimms commented Nov 24, 2020

/integrate

@openjdk openjdk bot closed this Nov 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 24, 2020
@openjdk
Copy link

openjdk bot commented Nov 24, 2020

@MrSimms Pushed as commit 9108c12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8256929 branch Nov 24, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant