Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257028: [type-restrictions] Assorted issues with generation of RestrictedField attributes from annotations #278

Closed

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Nov 25, 2020

  • Fix trouble with type annotating reference projection type
    • Change retention of experimental annotation to SOURCE
    • Fix javac crash with separate compilation
    • Improve robusness of tests

Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (5/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8257028: [type-restrictions] Assorted issues with generation of RestrictedField attributes from annotations

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/278/head:pull/278
$ git checkout pull/278

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into type-restrictions will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257028: [type-restrictions] Assorted issues with generation of RestrictedField attributes from annotations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the type-restrictions branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-restrictions branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Nov 25, 2020

/integrate

@openjdk openjdk bot closed this Nov 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@sadayapalam Pushed as commit 4902cf9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sadayapalam sadayapalam deleted the JDK-8257028 branch Nov 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant