Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231500: [lworld] Merge the experimental bytecode API #279

Closed
wants to merge 5 commits into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Nov 25, 2020

  • Moved to a single bytecode testing API
  • Cleaned out vbytecodes
  • Cleanup of tests not actually using the API
  • Removed TestNativeClone's API usage since cooking the method handle could no
    longer bypass the verifier's bad access check

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8231500: [lworld] Merge the experimental bytecode API

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/279/head:pull/279
$ git checkout pull/279

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@MrSimms MrSimms requested a review from mlchung Nov 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2020

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8231500: [lworld] Merge the experimental bytecode API

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the lworld branch:

  • 8680152: 8257422: [lworld] Problems with scalarized inline type return and incremental inlining
  • 8efeb68: Merge jdk
  • 7aed9b6: 8256016: Dacapo24H.java failed with "assert(false) failed: unscheduable graph"
  • 26e6cb3: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners
  • 911f16d: 8257056: Submit workflow should apt-get update to avoid package installation errors
  • b0bd0c2: 8256755: Update build.tools.depend.Depend to handle record components in API signatures
  • 9aeadbb: 8256865: Foreign Memory Access and Linker API are missing NPE checks
  • 8cd2e0f: 8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
  • cdb41ba: 8255904: Remove superfluous use of reflection in Class::isRecord
  • c45725e: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
  • ... and 141 more: https://git.openjdk.java.net/valhalla/compare/9108c1242f5a1ccaa13848db0772330f9ab4725e...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2020

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Looks okay in general. For the new methods like isValue, valueType and putValueClass etc, they should be renamed to reflect the new terminology (inline class).

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@MrSimms Since your change was applied there have been 151 commits pushed to the lworld branch:

  • 8680152: 8257422: [lworld] Problems with scalarized inline type return and incremental inlining
  • 8efeb68: Merge jdk
  • 7aed9b6: 8256016: Dacapo24H.java failed with "assert(false) failed: unscheduable graph"
  • 26e6cb3: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners
  • 911f16d: 8257056: Submit workflow should apt-get update to avoid package installation errors
  • b0bd0c2: 8256755: Update build.tools.depend.Depend to handle record components in API signatures
  • 9aeadbb: 8256865: Foreign Memory Access and Linker API are missing NPE checks
  • 8cd2e0f: 8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
  • cdb41ba: 8255904: Remove superfluous use of reflection in Class::isRecord
  • c45725e: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
  • ... and 141 more: https://git.openjdk.java.net/valhalla/compare/9108c1242f5a1ccaa13848db0772330f9ab4725e...lworld

Your commit was automatically rebased without conflicts.

Pushed as commit 972a751.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8231500 branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants