Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251966: [lworld] TestArrays.java fails with -XX:+ExpandSubTypeCheckAtParseTime #281

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Nov 26, 2020

JDK-8251442 added SubTypeCheckNode optimizations that make sure that the control path consistently dies with the data path. These need to be implemented in CmpPNode::sub as well which requires TypeKlassPtr to keep track of not null-free/flat properties for array klasses.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (1/5 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (9/9 running) (1/9 failed)

Failed test tasks

Issue

  • JDK-8251966: [lworld] TestArrays.java fails with -XX:+ExpandSubTypeCheckAtParseTime

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/281/head:pull/281
$ git checkout pull/281

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251966: [lworld] TestArrays.java fails with -XX:+ExpandSubTypeCheckAtParseTime

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 89dde2a: 8257154: [lworld] AndLNode::Identity optimization does not handle top input
  • 9108c12: 8256929: [lworld] Fails to compile with --with-debug-level=optimized

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Nov 26, 2020

/integrate

@openjdk openjdk bot closed this Nov 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2020

@TobiHartmann Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 89dde2a: 8257154: [lworld] AndLNode::Identity optimization does not handle top input
  • 9108c12: 8256929: [lworld] Fails to compile with --with-debug-level=optimized

Your commit was automatically rebased without conflicts.

Pushed as commit c2b5f11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant